See link for JB Weld... It's basically an excellent epoxy. You can get from Home Depot and other locations. I have used it to fix leaky radiators with excellent results.
http://www.jbweld.co.uk/
No, JB weld would not be able to hold the spring in place by itself....what it does is hold the retainer clip in place so it does not slip or move. I believe that over time, slight shifting on the clip leads to the eventual failure. Your threading idea is also excellent but one would have to be careful about how deep those threads go...in your pic, there seems to be a hollow center to the shaft, it this so? Memory fails me.
JB Weld is a good glue but cannot be used to replace metal before threading (no matter what the claims...lol) An excellent product for that would be Alumaloy..
http://www.alumaloy.net/. Come to think of it, you could use alumaloy to weld the whole thing into place (minus fusing the spring of course).
My JB weld fix would only be effective on a unit that was not too far gone...as in missing so much metal that the clip stands no chance of gripping. What I did was bend the clip's teeth back down to center so it would bit harder and I also scored the area on the shaft that the teeth would bite into. That gives the clip a firm hold. Once all that is done, apply JB Weld to the clip and the shaft protruding from it. I didn't have to take much apart to do this and it's held it for years.